This repository has been archived by the owner on Aug 23, 2020. It is now read-only.
Fix: Update solidity of transactions from past to present in TransactionValidator #1492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the
TransactionValidator
'scheckSolidity()
method to use aLinkedHashSet
in order to keep the order in which transactions got analyzed. TheTransactionViewModel
'supdateSolidTransactions()
method will then update the solid flag of the given txs in reverse order to guarantee that the flags are updated from past to present.refs: #1491
Fixes # (issue)
#1187 (maybe)
#1292 (maybe)
Type of change
How Has This Been Tested?
Private Net.
Checklist: