This repository has been archived by the owner on Aug 23, 2020. It is now read-only.
Fix: prevent self initialized connection being removed from reconnect pool too early #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we init. a conn. ourselves, we should not remove that URI from the reconnect pool up on the initialized (but not handshaked!) connection, because it will lead to the node not retrying a reconnect attempt in case the handshaking/read op. was faulty. Signed-off-by: Luca Moser <moser.luca@gmail.com>
luca-moser
changed the title
GalRogozinski
approved these changes
Jul 10, 2019
|
Fixes #1507 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we initialize a connection to a neighbor ourselves, we should not remove that URI from the reconnect
pool up on the initialized (but not handshaked) connection, because it will lead to the node
not retrying a reconnect attempt in case the handshaking/read op. was faulty.
Type of change
Checklist: