Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Fix file descriptors leak: ScriptException is not the only propagated… #1669

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

nkaraman
Copy link
Contributor

@nkaraman nkaraman commented Nov 21, 2019

… by scriptEngine

Description

Bug fix of file descriptors leak similar to described in https://stackoverflow.com/questions/31237918/file-descriptor-leak-example

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Documentation Fix

How Has This Been Tested?

All tests are passing

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@kwek20 kwek20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Good catch!

@GalRogozinski GalRogozinski merged commit 9dad25d into iotaledger:dev Nov 21, 2019
acha-bill pushed a commit to acha-bill/iri that referenced this pull request Nov 26, 2019
@GalRogozinski GalRogozinski mentioned this pull request May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants