Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Fix: Don't resave the transaction itself #1671

Merged
merged 1 commit into from
Dec 1, 2019

Conversation

GalRogozinski
Copy link
Contributor

Description

While rescanning the DB we are not suppose to re-save the existing transactions themselves.
Unfortunately it seems like we were re-saving the transactions and dropping the TAG data itself.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

Currently I am rescanning a node. I will validate that Tag information is present before merging.
Complete regression test should be done seperatly in #1466

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@acha-bill acha-bill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@GalRogozinski GalRogozinski merged commit 8a61193 into iotaledger:dev Dec 1, 2019
@GalRogozinski GalRogozinski mentioned this pull request May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants