This repository has been archived by the owner on Aug 23, 2020. It is now read-only.
Fix: Remove neighbors correctly #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalRogozinski
suggested changes
Dec 26, 2019
Comment on lines
785
to
786
| boolean isSeen = reconnectPool.contains(neighborURI); | ||
| reconnectPool.remove(neighborURI); |
There was a problem hiding this comment.
boolean isSeen = reconnectPool.remove(neighborURI);
| if (neighbor == null) { | ||
| if(isSeen){ |
There was a problem hiding this comment.
please auto-format this line
GalRogozinski
approved these changes
Jan 5, 2020
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the node has attempted to add a neighbour whether successfully or not, then removing the neighbour should return 'ok'.
Fixes #1586
Type of change
How Has This Been Tested?
Checklist: