Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Fix: Ensure proper creation of solid entrypoints #1702

Merged
merged 3 commits into from
Jan 5, 2020

Conversation

GalRogozinski
Copy link
Contributor

Description

Enforces the following definition for a solid entry point:

A transaction is considered a solid entry point if it is a bundle tail that can be traversed down from a non-orphaned transaction that was approved by a milestone that is above the last local snapshot. Or if it is a bundle tail of a non-orphaned transaction that was approved by a milestone that is above the last local snapshot.

Before non-tails could have been solid entry point, this caused problems in the case they were common to different bundles.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@GalRogozinski
Copy link
Contributor Author

GalRogozinski commented Jan 4, 2020

We may want to release this quick as a hotfix.
My manual tests should suffice. A unit test can be created later...

Also this is not the most efficient implementation regarding db queries, but this can also be tended to later.

@GalRogozinski
Copy link
Contributor Author

After enough testing this will be merged w/o review in order to advance the release of the hotfix...
Can be later changed with subsequent PRs

@GalRogozinski GalRogozinski changed the title Patch solid entrypoints Fix: Ensure proper creation of solid entrypoints Jan 5, 2020
Copy link
Contributor

@acha-bill acha-bill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants