This repository has been archived by the owner on Aug 23, 2020. It is now read-only.
Fix reference transaction logic #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwek20
reviewed
Jan 30, 2020
| @@ -24,6 +24,8 @@ def compare_thread_return(step, api_call): | |||
| # Exclude duration from response list | |||
| if 'duration' in response_list: | |||
| del response_list['duration'] | |||
| if 'info' in response_list: | |||
There was a problem hiding this comment.
This is for checkConsistency negative responses. The length of arguments wasn't matching because info was not included in the expected responses list
GalRogozinski
approved these changes
Jan 30, 2020
kwek20
approved these changes
Jan 30, 2020
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A fix for transaction issuance referencing another transaction in the regression tests. The machine 4 tests are reliant on this and have been exhibiting failures using the pool logic. This replaces the pool logic with simple synchronous api calls to ensure the test follows through properly.
Fixes: #1736
Type of change
How Has This Been Tested?
Checklist: