This repository has been archived by the owner on Aug 23, 2020. It is now read-only.
added bundle validity rules #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acha-bill
force-pushed
the
bundle-validity
branch
from
f2c04ca to
ce190ae
Compare
| public static Validity validateBundleTransactionsApproval(List<TransactionViewModel> bundleTxs){ | ||
| Hash headTrunkTransactionHash = bundleTxs.get(bundleTxs.size() - 1).getTrunkTransactionHash(); | ||
| for(int i = 0; i < bundleTxs.size() - 1; i++){ | ||
| if(!bundleTxs.get(i).getBranchTransactionHash().equals(headTrunkTransactionHash)){ |
There was a problem hiding this comment.
usually I don't like all those concatenated gets becuase they mask nulls
but I think here no nulls would appear anyhows
acha-bill
force-pushed
the
bundle-validity
branch
from
9114a60 to
e19b91f
Compare
acha-bill
force-pushed
the
bundle-validity
branch
from
e19b91f to
47f5497
Compare
acha-bill
force-pushed
the
bundle-validity
branch
from
47f5497 to
75938f2
Compare
kwek20
approved these changes
Mar 13, 2020
GalRogozinski
approved these changes
Mar 16, 2020
GalRogozinski
pushed a commit
to GalRogozinski/iri
that referenced
this pull request
Mar 17, 2020
* added bundle validity rules * commented on test and added invalid bundle tests * Fix: lower error severity for faulty neighbor to warning (iotaledger#1710) Co-authored-by: Dyrell Chapman <dyrell.chapman@iota.org>
GalRogozinski
pushed a commit
to GalRogozinski/iri
that referenced
this pull request
Mar 17, 2020
* added bundle validity rules * commented on test and added invalid bundle tests * Fix: lower error severity for faulty neighbor to warning (iotaledger#1710) Co-authored-by: Dyrell Chapman <dyrell.chapman@iota.org>
6 tasks
|
Manual tests: rule 1: It only approves tail transactions rule 2: All transactions within the bundle approve via their branch the trunk transaction of the head transaction Db and source here: https://github.com/acha-bill/iri_bundle_validity |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds 2 new rules for bundle validity. A bundle is valid if:
Fixes #1746
Type of change
How Has This Been Tested?
Checklist: