Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Fix: resolve race in networking layer assigning write operation to key #1865

Merged
merged 3 commits into from
May 25, 2020

Conversation

GalRogozinski
Copy link
Contributor

Description of change

Tries to solve the syncing problem from #1863 by synchronizing between registering of operation to keys, to ensure no race conditions...

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

It was ran w.o. data races and no noticeable sync slow down

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@GalRogozinski GalRogozinski requested a review from DyrellC May 20, 2020 22:16
Copy link
Contributor

@DyrellC DyrellC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I synced a node using this code from 15k milestones back on mainnet, green lights all around. No stalls.

@GalRogozinski GalRogozinski merged commit 6d66e61 into iotaledger:release-v1.8.6 May 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants