RFC: Milestone Payload #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubcech
requested review from
GalRogozinski,
luca-moser,
thibault-martinez and
Wollac
alexsporn
reviewed
Aug 6, 2020
* Multiple signature RFC extension * We are going for multisignature; we are going for Ed25519 * Fix typos, explain signature provider role better * Validation also needs to be numbered list * Reccomended key rotation frequency * Quorum rephrasing * Use <> for composite types
Co-authored-by: Thibault Martinez <thibault.martinez.30@gmail.com>
karimodm
suggested changes
Oct 30, 2020
|
|
||
| # Unresolved questions | ||
|
|
||
| - Forcing matching `Parent1`, `Parent2` in the _Milestone Payload_ and its _Message_ makes it impossible to reattach the same payload at different positions in the Tangle. While this does not prevent reattachments in general (a different, valid `Nonce`, for example would lead to a new Message ID), this still simplifies milestone processing. However, it violates a clean separation of payload and message. As such, it might still be desirable to slightly complicate the milestone processing in order to allow any reattachments of _Milestone Payloads_ by not validating the parents. |
There was a problem hiding this comment.
"in order to allow"?
we must not allow reattachments
There was a problem hiding this comment.
It seems to be practically infeasible/impossible to completely prevent reattachments. As such, it is much easier and cleaner to consider the Milestone as a "virtual marker" located at the corresponding position than an actual message location. I've adapted the RFC to clarify this aspect.
Wollac
approved these changes
Jan 6, 2021
|
@capossele since I am not sure how much of your original proposal is left, I've just requested a quick review from you 😅 |
capossele
approved these changes
Jan 6, 2021
karimodm
approved these changes
Jan 11, 2021
thibault-martinez
requested changes
Jan 12, 2021
Co-authored-by: Thibault Martinez <thibault.martinez.30@gmail.com>
add validation rules
Wollac
approved these changes
Oct 26, 2021
thibault-martinez
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered Version
Author: @capossele