Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of the purple set #21

Closed

Conversation

JakeSCahill
Copy link

@JakeSCahill JakeSCahill commented Jul 29, 2020

The RFC describes an ordering algorithm based on depth-first search, where you travel down the trunk of a milestone first, then down the branch.

I tried the example, and I think maybe O and N were the wrong way round.

So you would:

  • Apply I
  • Go back to O
  • Apply K
  • Apply O
  • Go back to S
  • Apply N
  • Apply S
  • Apply V

@thibault-martinez
Copy link
Member

thibault-martinez commented Jul 29, 2020

Hmm, you don't go back to O after applying I, you go back to K ?
You always want to go trunk first then branch, so from V it would be (skipping the upper part with trunk) V->S->N->K->I.

@JakeSCahill
Copy link
Author

Where would O go?

@thibault-martinez
Copy link
Member

You access O through S, and O is the branch of S, so N (as trunk of S) has to come first

@JakeSCahill
Copy link
Author

Like in my changes?
D, G, J, L, M, R, I, K, N, O, S, V
{D, G, J, L, M, R, I, K, O, N, S, V}

@thibault-martinez
Copy link
Member

No, not like in your change. In your change O comes first. Why does O comes first when it's a branch and we say trunk have to come first ?

lzpap pushed a commit to lzpap/tips that referenced this pull request Feb 28, 2022
Remove Network ID, add Protocol Version
PhilippGackstatter added a commit that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants