Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIP-20 Transaction Payload with TIP-18 Output Types #40

Merged
merged 43 commits into from
Aug 31, 2022

Conversation

lzpap
Copy link
Member

@lzpap lzpap commented Nov 18, 2021

Description

TIP-18 Introduces new output types, unlocks and output features that modify Transaction Payload structure and validation rules.

This PR adds these modification to the original Transaction Payload definition (#18) with the goal of replacing TIP-7.

View

Rendered Document

lzpap and others added 3 commits November 18, 2021 17:26
New output types, unlock blocks and output feature blocks
are introduced in RFC-0038 that modify the Transaction Payload
structure and validation rules.
@lzpap lzpap changed the title Update Transaction Payload RFC with New Output Types TIP-20 Transaction Payload with New Output Types Dec 15, 2021
Copy link
Member

@Thoralf-M Thoralf-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Address reuse and Rationale and alternatives sections still have information from the old RFC about W-OTS, which shouldn't be there anymore, since we removed that already with Chrysalis Part 2

Copy link
Contributor

@Dr-Electron Dr-Electron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooohhh man. What a rabbit hole I've fallen into now. I just wanted to look at NFT outputs again 😅
What a mess. I hope this review helps somehow. :trollface:

text/0018-transaction-payload/0018-transaction-payload.md Outdated Show resolved Hide resolved
text/0018-transaction-payload/0018-transaction-payload.md Outdated Show resolved Hide resolved
text/0018-transaction-payload/0018-transaction-payload.md Outdated Show resolved Hide resolved
text/0018-transaction-payload/0018-transaction-payload.md Outdated Show resolved Hide resolved
@Wollac Wollac changed the title TIP-20 Transaction Payload with New Output Types TIP-20 Transaction Payload with TIP-18 Output Types Jan 17, 2022
@Wollac
Copy link
Contributor

Wollac commented Jan 17, 2022

Created lzpap#1 to add Network ID to the signed Transaction Essence.

@lzpap lzpap mentioned this pull request Feb 4, 2022
11 tasks
 - Bump Tx Payload type to 6
 - Bump Tx Essence type to 1
 - Add Tagged Data as supported payload type instead of Indexation
lzpap added 2 commits March 4, 2022 11:53
Minting and melting are restricted to the foundry, while
burning is performed by the user without the need for the
foundry to be update.
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
<td valign="top">Unlocks <code>anyOf</code></td>
<td colspan="2">
<details>
<summary>Signature Unlock</summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table looks broken in my browser.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fixed now?

tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
tips/TIP-0020/tip-0020.md Show resolved Hide resolved
tips/TIP-0020/tip-0020.md Outdated Show resolved Hide resolved
lzpap and others added 10 commits August 30, 2022 10:41
Co-authored-by: Wolfgang Welz <welzwo@gmail.com>
Co-authored-by: Wolfgang Welz <welzwo@gmail.com>
Co-authored-by: Wolfgang Welz <welzwo@gmail.com>
Co-authored-by: Wolfgang Welz <welzwo@gmail.com>
Co-authored-by: Wolfgang Welz <welzwo@gmail.com>
Co-authored-by: Wolfgang Welz <welzwo@gmail.com>
Co-authored-by: Wolfgang Welz <welzwo@gmail.com>
Co-authored-by: Wolfgang Welz <welzwo@gmail.com>
Co-authored-by: Wolfgang Welz <welzwo@gmail.com>
Co-authored-by: Wolfgang Welz <welzwo@gmail.com>
@lzpap lzpap merged commit b72b40d into iotaledger:main Aug 31, 2022
@lzpap lzpap deleted the tx-updates branch August 31, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants