Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] support eth_call by height for Versioned DB #4270

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Liuhaai
Copy link
Member

@Liuhaai Liuhaai commented May 18, 2024

Description

The PR, based on the branch https://github.com/iotexproject/iotex-core/tree/archive, is to support historical "eth_call" for API nodes.
New methods are added into interfaces in impl
ContextAtHeight is added to blockchain module
SimulateExecutionAtHeight and ReadContractStorageAtHeight are added to statedb module

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@Liuhaai Liuhaai changed the title Archive api support Support eth_call by height for Versioned DB May 18, 2024
committee:
gravityChainAPIs:
# please change the infura key to your key (e.g., https://mainnet.infura.io/v3/YOUR_KEY)
- https://mainnet.infura.io/v3/b355cae6fafc4302b106b937ee6c15af

Check failure

Code scanning / SonarCloud

Infura API keys should not be disclosed High

Make sure this Infura API key gets revoked, changed, and removed from the code. See more on SonarCloud
@Liuhaai Liuhaai force-pushed the archive_api_support branch 2 times, most recently from 051d6bd to b690901 Compare May 20, 2024 20:24
@Liuhaai Liuhaai marked this pull request as ready for review May 20, 2024 21:00
@Liuhaai Liuhaai requested review from CoderZhi, dustinxie, envestcc and a team as code owners May 20, 2024 21:00
@Liuhaai Liuhaai changed the title Support eth_call by height for Versioned DB [api] support eth_call by height for Versioned DB May 20, 2024
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
21.0% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants