Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Transaction size fee #1091

Closed
webmaster128 opened this issue Dec 18, 2019 · 0 comments · Fixed by #1094
Closed

Implement Transaction size fee #1091

webmaster128 opened this issue Dec 18, 2019 · 0 comments · Fixed by #1094

Comments

@webmaster128
Copy link
Contributor

There should be an additional transaction fee that charges for the amount of bytes of the signed transaction.

In https://github.com/iov-one/transaction-size-fee/blob/master/simulate.py#L3-L10 there is the algorithm we discussed.

atomic is an appreviation for "atomic units [of IOV tokens]", i.e. 1 atomic is 0.000000001 IOV. All calculations should be done on integers of atomic units. With atomics stored as uint64 we can do safe math up to ~18 billion IOV, which should be sufficient for the transaction sizes we can expect.

With small modifications in the pythong script from above we can generate a nice set of test vectors.

The two constants FREE_CONTINGENT and MULTIPLIER should be configurable such that they can be changed over time.
@webmaster128 webmaster128 mentioned this issue Dec 18, 2019
Closed
3 tasks
husio added a commit that referenced this issue Dec 19, 2019
@husio
x/txfee: new extension
6989997 
A new extension `x/txfee` allows to configure an additional transaction
fee. Additional fee amount depends on the transaction binary size.
`x/txfee` is enabled in `cmd/bnsd` and can be confiured via `gcond`
based confiuration.

`cmd/bnscli` was updated to support new extension.

Batch transaction fee is computed only once for the original transaction
and not for each message that batch contains.

resolve #1091
@husio husio mentioned this issue Dec 19, 2019
Merged
husio added a commit that referenced this issue Dec 20, 2019
@husio
x/txfee: new extension
67522c2 
A new extension `x/txfee` allows to configure an additional transaction
fee. Additional fee amount depends on the transaction binary size.
`x/txfee` is enabled in `cmd/bnsd` and can be confiured via `gcond`
based confiuration.

`cmd/bnscli` was updated to support new extension.

Batch transaction fee is computed only once for the original transaction
and not for each message that batch contains.

resolve #1091
husio added a commit that referenced this issue Dec 20, 2019
@husio
x/txfee: new extension
fb72b71 
A new extension `x/txfee` allows to configure an additional transaction
fee. Additional fee amount depends on the transaction binary size.
`x/txfee` is enabled in `cmd/bnsd` and can be confiured via `gcond`
based confiuration.

`cmd/bnscli` was updated to support new extension.

Batch transaction fee is computed only once for the original transaction
and not for each message that batch contains.

resolve #1091
husio added a commit that referenced this issue Dec 27, 2019
@husio
x/txfee: new extension (#1094)
a77da1d 
A new extension `x/txfee` allows to configure an additional transaction
fee. Additional fee amount depends on the transaction binary size.
`x/txfee` is enabled in `cmd/bnsd` and can be confiured via `gcond`
based confiuration.

`cmd/bnscli` was updated to support new extension.

Batch transaction fee is computed only once for the original transaction
and not for each message that batch contains.

resolve #1091
@aaronc aaronc mentioned this issue May 13, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

x/txfee: new extension iov-one/weave
1 participant
@webmaster128