Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GetDownloadSpec to GetDownloadClause #29

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Conversation

ffoulkes
Copy link
Collaborator

@ffoulkes ffoulkes commented Oct 9, 2023

  • Rename the GetDownloadSpec() cmake function to GetDownloadClause().

Improve the readability of the build system by:

  • Giving the function a name that better describes what it does.
  • Using an output variable name (_download_clause) that is more obviously local to the file in which it appears, and that better describes its purpose.

- Rename the GetDownloadSpec() cmake function to GetDownloadClause().

Signed-off-by: Derek G Foster <derek.foster@intel.com>
@ffoulkes ffoulkes added the cmake Affects CMake build system label Oct 9, 2023
CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Copy link
Collaborator

@nupuruttarwar nupuruttarwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffoulkes ffoulkes merged commit 06c2a14 into main Oct 9, 2023
1 check passed
@ffoulkes ffoulkes deleted the download-clause branch October 9, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Affects CMake build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants