Upgrade grpc, protobuf and abseil-cpp + enable CXX_STANDARD by default #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sabeel Ansari <sabeel.ansari@intel.com>
…tobuf and abseil Signed-off-by: Sabeel Ansari <sabeel.ansari@intel.com>
Signed-off-by: Sabeel Ansari <sabeel.ansari@intel.com>
5abeel
requested review from
ffoulkes,
nupuruttarwar,
n-sandeep and
vsureshkumarp
as code owners
ffoulkes
reviewed
Nov 9, 2023
Signed-off-by: Sabeel Ansari <sabeel.ansari@intel.com>
Signed-off-by: Sabeel Ansari <sabeel.ansari@intel.com>
Signed-off-by: Sabeel Ansari <sabeel.ansari@intel.com>
Merged
ffoulkes
added a commit
that referenced
this pull request
Nov 11, 2023
- Update abseil, grpc, and protobuf to track changes made in PR #41. Signed-off-by: Derek G Foster <derek.foster@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the following libraries and enables the
CMAKE_CXX_STANDARDand setsDCMAKE_CXX_STANDARD_REQUIRED=true.The above has been tested end-to-end to confirm working sanity check using P4RT and gNMI messages from respective clients.
Note: With the updated libraries, even with
--rpathflag, some libraries show up as as 'not found' underldd infrap4d. Workaround is to set theLD_LIBRARY_PATHto include stratum-deps/install/lib and stratum-deps/install/lib64.Will look into fixing this in future PR