Eliminate RECENT_PKGS option #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffoulkes
requested review from
nupuruttarwar,
n-sandeep and
vsureshkumarp
as code owners
- Replace each of the three RECENT_PKGS conditionals in protobuf.cmake with a component variable. - Define the PROTOBUF_ABSL_PROVIDER variable in components.json. - Update deps.cmake from components.json, eliminating the RECENT_PKGS conditional there. - Remove the definition of RECENT_PKGS from CMakeLists.txt. Signed-off-by: Derek G Foster <derek.foster@intel.com>
The custom build scripts are an artifact of experiments with newer versions of gRPC. They are no longer needed. Signed-off-by: Derek G Foster <derek.foster@intel.com>
Signed-off-by: Derek G Foster <derek.foster@intel.com>
ffoulkes
force-pushed
the
conditionals
branch
from
46df40d to
9c125ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace each of the three RECENT_PKGS conditionals in
protobuf.cmakewith a component variable.Define the PROTOBUF_ABSL_PROVIDER variable in
components.json.Use
components.pyto updatedeps.cmakefromcomponents.json, canonicalizingdeps.cmakeand removing the RECENT_PKGS conditional.Remove the definition of RECENT_PKGS from
CMakeLists.txt.