Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firewalllogs*dat: Simplify code for color calculation #19

Closed
wants to merge 20 commits into from

Conversation

alfh
Copy link
Contributor

@alfh alfh commented Feb 22, 2014

Remove unnecessary code for setting colors on rows.

alfh and others added 20 commits February 16, 2014 07:54
Replace 10 if statements with duplicated code for print
and setting background color by using a variable and
one if statement.
Add support for caching package files for ArchLinux in updxlrator, by
adding pkg.tar.xz to the regular expression for Linux vendor.
The updatexlrator.cgi is assuming that colon is not part of any
filenames downloaded by updxlrator. Fix this by fixing regular
expression used for listing pending download files, and by
fixing regular expression used to listing files in maintenance view.

The fix for listing in maintenance is not very nice, I just use
":separator:" as field separator instead of just ":", which was used
earlier. This should make it very unlikely to collide with a part of
the filename.

Also make the files in download be sorted using lower case, like it is
done for files in the vendor path.

The problem can be reproduced by downloading
http://mirror.us.leaseweb.net/archlinux/community/os/x86_64/
docker-1:0.7.6-1-x86_64.pkg.tar.xz, after pkg.tar.xz files support has
been added to updxlrator.
The menus in the new default theme does not work properly on
ipad and I guess other devices using mobile safari.

The reason is that <a> tags without href is not marked as
clickable by ios, and therefore no css hover effect is applied.

The fix is either to add a href="#" attribute
or a onclick="return true;" atribute on the <a> tag.
I prefer the href solution, since it is a no javascript solution.
qos.cgi and media.cgi depend on swapVisibility function, this
is defined in each theme, but was missing from the new theme.

Add the function, and implement it using jquery, since jquery
is always present in the new theme.
The proper way to mark readonly is to use readonly="readonly", not
readonly="true", like it was done some places.
Almost all of <input type="image"... has both an alt and a
title attribute, but some are missing title, and when the icon
is not very clear, it makes it harder to understand what the icon
does. By adding title, the browser displays text when mouse pointer
is over the icon.

Also add missing quotes for alt and title attributes where needed.
Add missing colon and put them into one column in the
table.
@alfh
Copy link
Contributor Author

alfh commented Feb 22, 2014

Problems with rebasing, closing this

@alfh alfh closed this Feb 22, 2014
@alfh alfh deleted the feature_cgibin_cleanup branch February 22, 2014 16:49
mtremer pushed a commit that referenced this pull request May 14, 2021
- Update from 0.2.7 to 0.2.10
- Convert from python-inotify to python3-inotify
   make.sh, lfs & rootfiles
- Update rootfiles
- Changelog
  0.2.8: - We now just *skip* the event if not known
    - Implement InotifyTree and InotifyTrees as sub-classes of new BaseTree
      class
    - Made InotifyTree and InotifyTrees sub-classes of new base class
      BaseTree
    - Recursively watch a list of paths/trees
  0.2.9: - Added getter for Inotify object from tree objects
    - Added note to docs about race-conditions. Added small change for
      redundant adds.
    - Slightly reorganized documentation. Updated example.
    - Merge pull request #35 from dsoprea/dustin. Added extensive unit-test
      coverage. Closes all bug requests.
    - Added large amount of unit-test coverage.
       - Now handle rename-specific events.
       - Can now also ignore issues with new directories not existing if
         you're created *and* deleted or renamed a folder since the last
         time events were read.
       - Adjusted requirements for simplicity.
       - Added Python 3 compatibility.
       - Fixed Unicode support.
       - Can now provide `filter_predicate` to event_gen() to allow custom
         loop termination based on events.
       - We'll now terminate the loop when certain events are encountered.
         These events are passed into event_gen() as `terminal_events`. By
         default these are the IN_Q_OVERFLOW and IN_UNMOUNT types.
       - Fixes #28
       - Fixes #23
       - Fixes #22
       - Fixes #19
       - Fixes #16
       - Fixes #15
       - Fixes #5
    - Check presence of both glibc errno and musl libc err
    - Support for musl libc (Alpine Linux)
    - Merge pull request #27 from jessesuen/master. Support for musl libc
      (Alpine Linux)
    - Check presence of both glibc errno and musl libc err
    - Merge pull request #26 from hathcock/hathcock/issue-25. resolves #25,
      list of binary paths can't be logged with existing call
       - Support for musl libc (Alpine Linux)
       - Resolves #25, list of binary paths can't be logged with existing
         call
  0.2.10: - Merge pull request #34 from davidparsson/
            feature/support-moved-directories
      - Support MOVED_FROM and MOVED_TO in BaseTree
    - events: Now log event types from epoll vs data stream.
    - This release implicitly fixed the botched binary package released
      in 0.2.9

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
Reviewed-by: Peter Müller <peter.mueller@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
mtremer pushed a commit that referenced this pull request Feb 14, 2022
- Update from 2.3.3op2 to 2.4.1
- Update of rootfile
- Changelog
   Changes in CUPS v2.4.1 (27th January 2020)
     - The default color mode now is now configurable and defaults to the printer's
       reported default mode (Issue #277)
     - Configuration script now checks linking for -Wl,-pie flags (Issue #303)
     - Fixed memory leaks - in testi18n (Issue #313), in `cups_enum_dests()`
       (Issue #317), in `_cupsEncodeOption()` and `http_tls_upgrade()` (Issue #322)
     - Fixed missing bracket in de/index.html (Issue #299)
     - Fixed typos in configuration scripts (Issues #304, #316)
     - Removed remaining legacy code for `RIP_MAX_CACHE` environment variable
       (Issue #323)
     - Removed deprecated directives from cupsctl and cups-files.conf (Issue #300)
     - Removed `purge-jobs` legacy code from CGI scripts and templates (Issue #325)
   Changes in CUPS v2.4.0 (29th November 2021)
     - Added configure option --with-idle-exit-timeout (Issue #294)
     - Added --with-systemd-timeoutstartsec configure option (Issue #298)
     - DigestOptions now are applied for MD5 Digest authentication defined
       by RFC 2069 as well (Issue #287)
     - Fixed compilation on Solaris (Issue #293)
     - Fixed and improved German translations (Issue #296, Issue #297)
   Changes in CUPS v2.4rc1 (12th November 2021)
     - Added warning and debug messages when loading printers
      if the queue is raw or with driver (Issue #286)
     - Compilation now uses -fstack-protector-strong if available (Issue #285)
   Changes in CUPS v2.4b1 (27th October 2021)
     - Added support for CUPS running in a Snapcraft snap.
     - Added basic OAuth 2.0 client support (Issue #100)
     - Added support for AirPrint and Mopria clients (Issue #105)
     - Added configure support for specifying systemd dependencies in the CUPS
       service file (Issue #144)
     - Added several features and improvements to `ipptool` (Issue #153)
     - Added a JSON output mode for `ipptool`.
     - The `ipptool` command now correctly reports an error when a test file cannot
       be found.
     - CUPS library now uses thread safe `getpwnam_r` and `getpwuid_r` functions
       (Issue #274)
     - Fixed Kerberos authentication for the web interface (Issue #19)
     - The ZPL sample driver now supports more "standard" label sizes (Issue #70)
     - Fixed reporting of printer instances when enumerating and when no options are
       set for the main instance (Issue #71)
     - Reverted USB read limit enforcement change from CUPS 2.2.12 (Issue #72)
     - The IPP backend did not return the correct status code when a job was canceled
       at the printer/server (Issue #74)
     - The `testlang` unit test program now loops over all of the available locales
       by default (Issue #85)
     - The `cupsfilter` command now shows error messages when options are used
       incorrectly (Issue #88)
     - The PPD functions now treat boolean values as case-insensitive (Issue #106)
     - Temporary queue names no longer end with an underscore (Issue #110)
     - The USB backend now runs as root (Issue #121)
     - Added pkg-config file for libcups (Issue #122)
     - Fixed a PPD memory leak caused by emulator definitions (Issue #124)
     - Fixed a `DISPLAY` bug in `ipptool` (Issue #139)
     - The scheduler now includes the `[Job N]` prefix for job log messages, even
       when using syslog logging (Issue #154)
     - Added support for locales using the GB18030 character set (Issue #159)
     - `httpReconnect2` did not reset the socket file descriptor when the TLS
       negotiation failed (Apple #5907)
     - `httpUpdate` did not reset the socket file descriptor when the TLS
       negotiation failed (Apple #5915)
     - The IPP backend now retries Validate-Job requests (Issue #132)
     - Now show better error messages when a driver interface program fails to
       provide a PPD file (Issue #148)
     - Added dark mode support to the CUPS web interface (Issue #152)
     - Added a workaround for Solaris in `httpAddrConnect2` (Issue #156)
     - Fixed an interaction between `--remote-admin` and `--remote-any` for the
       `cupsctl` command (Issue #158)
     - Now use a 60 second timeout for reading USB backchannel data (Issue #160)
     - The USB backend now tries harder to find a serial number (Issue #170)
     - Fixed `@IF(name)` handling in `cupsd.conf` (Apple #5918)
     - Fixed documentation and added examples for CUPS' limited CGI support
       (Apple #5940)
     - Fixed the `lpc` command prompt (Apple #5946)
     - Now always pass "localhost" in the `Host:` header when talking over a domain
       socket or the loopback interface (Issue #185)
     - Fixed a job history update issue in the scheduler (Issue #187)
     - Fixed `job-pages-per-set` value for duplex print jobs.
     - Fixed an edge case in `ippReadIO` to make sure that only complete attributes
       and values are retained on an error (Issue #195)
     - Hardened `ippReadIO` to prevent invalid IPP messages from being propagated
       (Issue #195, Issue #196)
     - The scheduler now supports the "everywhere" model directly (Issue #201)
     - Fixed some IPP Everywhere option mapping problems (Issue #238)
     - Fixed support for "job-hold-until" with the Restart-Job operation (Issue #250)
     - Fixed the default color/grayscale presets for IPP Everywhere PPDs (Issue #262)
     - Fixed support for the 'offline-report' state for all USB backends (Issue #264)
     - Documentation fixes (Issue #92, Issue #163, Issue #177, Issue #184)
     - Localization updates (Issue #123, Issue #129, Issue #134, Issue #146,
       Issue #164)
     - USB quirk updates (Issue #192, Issue #270, Apple #5766, Apple #5838,
       Apple #5843, Apple #5867)
     - Web interface updates (Issue #142, Issue #218)
     - The `ippeveprinter` tool now automatically uses an available port.
     - Fixed several Windows TLS and hashing issues.
     - Deprecated cups-config (Issue #97)
     - Deprecated Kerberos (`AuthType Negotiate`) authentication (Issue #98)
     - Removed support for the (long deprecated and unused) `FontPath`,
       `ListenBackLog`, `LPDConfigFile`, `KeepAliveTimeout`, `RIPCache`, and
       `SMBConfigFile` directives in `cupsd.conf` and `cups-files.conf`.
     - Stubbed out deprecated `httpMD5` functions.
     - Add test for undefined page ranges during printing.

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
Reviewed-by: Peter Müller <peter.mueller@ipfire.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants