Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check flag really do it #854

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

0x5459
Copy link
Collaborator

@0x5459 0x5459 commented Jul 31, 2023

关联的Issues (Related Issues)

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合 Venus 项目管理规范中关于 PR 的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的 commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit 3cab73a into main Jul 31, 2023
3 checks passed
@LinZexiao LinZexiao deleted the fix/0x5459/check-flag-really-do-it branch July 31, 2023 07:06
0x5459 added a commit that referenced this pull request Jul 31, 2023
…854-to-release-v0.7

Cherry pick pr #853 #854 to release/v0.7
0x5459 added a commit that referenced this pull request Jul 31, 2023
…854-to-release/v0.8

Cherry pick pr #853 #854 to release/v0.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants