Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #4759 venus-auth: add docker feature #75

Closed
wants to merge 5 commits into from
Closed

feat: #4759 venus-auth: add docker feature #75

wants to merge 5 commits into from

Conversation

LinZexiao
Copy link
Collaborator

@LinZexiao LinZexiao commented May 11, 2022

Related Issues

filecoin-project/venus#4759

Proposed Changes

add docker features
add github action for automaticly pushing to dockerhub

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc, perf, refactor, revert, style, test
    • area: venus, venus-messager, venus-miner, venus-gateway, venus-auth, venus-market, venus-sealer, venus-wallet, venus-cluster, api, chain, state, vm, data transfer, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in venus docs or Discussion Tutorials.
  • CI is green

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #75 (bb1803c) into main (896f44f) will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   30.14%   30.38%   +0.23%     
==========================================
  Files          30       30              
  Lines        2491     2472      -19     
==========================================
  Hits          751      751              
+ Misses       1623     1604      -19     
  Partials      117      117              
Flag Coverage Δ
unittests 30.38% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/jwtclient/auth_client.go 44.39% <0.00%> (ø)
cmd/jwtclient/auth_mux.go 5.37% <0.00%> (+0.91%) ⬆️

.github/workflows/build_upload.yml Show resolved Hide resolved
tags:
- '**'
push:
branches: [ docker ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是不是主分支[ main ]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对,这个是只监听docker分支的,主分支的已经写进原来那个统一的那个 工作流文件了。如果以后docker分支不保留的话,可以删掉,否则建议保留,这样可以方便dockers分支进行发布镜像测试

@diwufeiwen diwufeiwen deleted the branch main June 8, 2022 01:36
@diwufeiwen diwufeiwen closed this Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants