Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: git-action: enable golang-ci-lint checks on git action #208

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

zl03jsj
Copy link
Contributor

@zl03jsj zl03jsj commented Jul 13, 2022

changes:

  1. enable golang-cli-lint on git action.
  2. pass golang-cli-lint checks.
  3. remove duplicate go test ...

would resolve filecoin-project/venus#5081

@zl03jsj zl03jsj self-assigned this Jul 13, 2022
@zl03jsj zl03jsj marked this pull request as draft July 13, 2022 10:07
@codecov-commenter
Copy link

Codecov Report

Merging #208 (c451e98) into main (df5e882) will increase coverage by 0.08%.
The diff coverage is 24.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   16.14%   16.22%   +0.08%     
==========================================
  Files          53       53              
  Lines        5184     5183       -1     
==========================================
+ Hits          837      841       +4     
+ Misses       4263     4258       -5     
  Partials       84       84              
Flag Coverage Δ
unittests 16.22% <24.48%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/msg.go 0.00% <0.00%> (ø)
config/modules.go 31.42% <0.00%> (ø)
main.go 0.00% <0.00%> (ø)
metrics/trace.go 0.00% <ø> (ø)
models/mysql/address.go 0.00% <0.00%> (ø)
models/mysql/message.go 0.00% <0.00%> (ø)
models/mysql/node.go 0.00% <0.00%> (ø)
models/mysql/shared_params.go 0.00% <0.00%> (ø)
service/message_selector.go 0.00% <0.00%> (ø)
service/message_service.go 0.00% <0.00%> (ø)
... and 9 more

@zl03jsj zl03jsj force-pushed the feat/git-action/enable-checks-by-golang-ci-lint branch from c451e98 to da2ecf0 Compare July 14, 2022 02:28
@zl03jsj zl03jsj marked this pull request as ready for review July 14, 2022 02:29
@hunjixin
Copy link
Contributor

LGTM

@hunjixin hunjixin merged commit 7a62592 into main Jul 14, 2022
@hunjixin hunjixin deleted the feat/git-action/enable-checks-by-golang-ci-lint branch July 14, 2022 03:19
diwufeiwen pushed a commit that referenced this pull request Jul 18, 2022
* feat: #4759 venus-messager: add docker feature (#194)

* add: dockerfile &docker dir

* feat: add publish docker image action

* fix: change action trigger to making tag

* chore: rm the test workflow of docker

* style: add blank line to the end of the file

* style:add reture to the end of file

* fix: venus-messager : change to  build docker image from local repo  (#197)

* fix: change to build image from local repo

* fix: get BUILD_DOCKER_PROXY var from env

* build: bump version to v1.6.0-rc1 (#196)

* feat: load builtin actors from bundle

* feat: use ~/.venus-messager store files

* fix: Simplify the configuration

* cmd: hidden --config flag

* chore: upgrade venus & gateway & auth

* chore: Remove the dependency on golang.org/x/xerrors

* build: bump version to v1.6.0-rc1

* build: v1.6.0-rc1 (#198)

* upgrade venus

* upgrade gateway

* feat: load builtin actors from bundle

* feat: use ~/.venus-messager store files

* chore: upgrade venus

* fix: Simplify the configuration

* cmd: hidden --config flag

* chore: upgrade venus & gateway & auth

* chore: Remove the dependency on golang.org/x/xerrors

* build: bump version to v1.6.0-rc1

* cmd: rmeove --sqlite-file flag

* fix: remove messager.toml

* doc: update README.md

* cmd: Fix incorrect configuration loading

* cmd: fix actor code not registed

* chore: upgrade gateway & venus

* chore: upgrade venus & venus-auth

* doc: update READMD.md

* build: build v1.6.0-rc2 (#199)

* fix: upgrade venus & simplified MessagePaser logic

* docs: update README.md

* chore: upgrade venus

* chore: upgrade venus & venus-gateway

* chore: use go 1.17 in go.mod

* build: bump version to v1.6.0-rc2

* chore: bump version to v1.6.0 (#200)

* chore: upgrade venus & auth & gateway

* chore: bump version to v1.6.0

* fix: sort msg before push (#202)

* fix: update dependencies to ddl (#201)

* docs: migrate from venus-docs (#203)

* docs: migrate from venus-docs

* feat:support fil unit in replace command (#206)

* feat: add gas over premium (#205)

* feat: add gas over premium

* fix: not check empty string (#207)

* chore: git-action: enable golang-ci-lint checks on git action (#208)

* enable golang-ci-lint checks on git action

* feat: rm ddl copying when docker was build (#211)

* only trigger auto publish on PR merged (#212)

* feat: add batch replace cmd (#210)

* cmd: add batch replace cmd & upgrade venus

* fix: update the tipset_key field of the messages table to varchar(2048) (#213)

Co-authored-by: LinZexiao <55120714+LinZexiao@users.noreply.github.com>
Co-authored-by: tom <69969590+simlecode@users.noreply.github.com>
Co-authored-by: Yu <tctctcly@gmail.com>
Co-authored-by: Mike <41407352+hunjixin@users.noreply.github.com>
zl03jsj added a commit that referenced this pull request Jul 18, 2022
* enable golang-ci-lint checks on git action
simlecode pushed a commit that referenced this pull request Jul 22, 2022
hunjixin added a commit that referenced this pull request Jul 22, 2022
* fix: update dependencies to ddl (#201)

* docs: migrate from venus-docs (#203)

* docs: migrate from venus-docs

* feat:support fil unit in replace command (#206)

* feat: add gas over premium (#205)

* feat: add gas over premium

* fix: not check empty string (#207)

* chore: git-action: enable golang-ci-lint checks on git action (#208)

* enable golang-ci-lint checks on git action

* feat: rm ddl copying when docker was build (#211)

* only trigger auto publish on PR merged (#212)

* feat: add batch replace cmd (#210)

* cmd: add batch replace cmd & upgrade venus

* fix: update the tipset_key field of the messages table to varchar(2048) (#213)

* fix: use v1api for node (#214)

* fix: use v1api for node

* docs: update docs (#219)

* docs: add gas_over_premium to design-specs.md

* docs: update getting-started.md

* docs: add venus-messager-tools.md

Co-authored-by: LinZexiao <55120714+LinZexiao@users.noreply.github.com>
Co-authored-by: Yu <tctctcly@gmail.com>
Co-authored-by: Mike <41407352+hunjixin@users.noreply.github.com>
Co-authored-by: zl <zl03jsj@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants