-
Notifications
You must be signed in to change notification settings - Fork 48
Conversation
|
||
![demo of v2.2.0](https://ipfs.io/ipfs/QmdJTmCxwcpoGbEVfT6b9j4RZJWNcF2GQG1Ajf9XB6XtVP) | ||
|
||
Why is it worth a blog post you ask? See the overview of key features below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it worth a blog post you ask?
No need to be too humble about it, the extension is rad. I'd drop that part.
author: lidel | ||
--- | ||
|
||
I am pleased to announce to everyone in our community that a new version of our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're using us
and we
in the rest of the post, so this should probably changed to be the same.
|
||
### Your node is exposed as `window.ipfs` on every webpage | ||
|
||
Websites can now detect if the property exists in window context and opt-in to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth adding a note that window.ipfs
exposes the same api as js-ipfs-api, and that we'd like to see people building apps that use it, perhaps with a link to one of the demos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is bit tricky for me. AFAIK we want window.ipfs
to be compatible with ipfs/interface-ipfs-core/, not a specific backend.
Maybe @alanshaw can help with wording it in a honest way?
See ipfs-inactive/ipfs-postmsg-proxy#18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's correct that window.ipfs
exposes the same API as js-ipfs-api
so it's fine to say that, and it might be easier for people to understand.
It's more correct to say that it exposes an interface-ipfs-core
compatible interface, but not everyone will know what that is. Note, js-ipfs-api
exposes a interface-ipfs-core
compatible interface too.
I also think it's ok to say it exposes the same API as js-ipfs-api
since you'll only be using window.ipfs
from JS anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2b65cc7 (preview) plays it safe by glossing over it like this:
The API aims to be compatible with interface-ipfs-core, which means websites can now detect if the property exists in window context and opt-in to use it instead of creating their own js-ipfs node.
Is it ok? (added links to demos at the end of section as well)
What is the next step? |
@lidel feel free to merge whenever you feel it's ready to be published and shared with the world :) Once in master, it'll be deployed to the live website. |
There is a small problem: I don't see "merge" button :) |
Fixed the permissions and I can tell you already saw it! 🥇 |
Draft of a post announcing IPFS Companion v2.2.0.
→ Rendered Preview @ 2b65cc7
cc @alanshaw @olizilla