This repository has been archived by the owner on Jun 2, 2020. It is now read-only.
Fix package scripts for macOS and improve setup instructions #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MacOS's grep does not have a `-P` option. I don't think these expressions need it though, so I just removed it. MacOS also does not support `|&`, so swap it out for `2>&1 |` to pipe combined stdout/stderr. License: MIT Signed-off-by: Rob Brackett <rob@robbrackett.com>
Include installation of AEgir, downloading/building package docs, and switch `hugo server` to `make serve` since, if we ever need it to do more, we probably want people calling Make instead of Hugo directly. License: MIT Signed-off-by: Rob Brackett <rob@robbrackett.com>
victorb
approved these changes
Apr 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve had these changes sitting around on my hard drive for a while but figured I ought to push them up before I started committing new content!
There are a few bits in
pkg2md.shthat aren’t supported in macOS; I think the changes I made should work across most all *nixes. I also addedAEgirandmake packagesto the setup instructions and switched the call to Hugo to usemakeinstead, since it seems like that’s what we’d want people doing if we ever add to the build process.