-
Notifications
You must be signed in to change notification settings - Fork 62
Add section one (What is IPFS?) of new intro doc #67
Conversation
This needs to be re-built on top of #68. The docs here should land in the new “introduction” section. |
This is a rewrite of 315ba71 that fits with the new site organization (which wasn't fully baked when this draft was originally written). License: MIT Signed-off-by: Rob Brackett <rob@robbrackett.com>
We didn't have our own documentation on hashes when this document was originally written. Now we do, so link to it! License: MIT Signed-off-by: Rob Brackett <rob@robbrackett.com>
315ba71
to
0e5b04d
Compare
Rewritten to build nicely on top of current master. (a lot has changed since this was originally written!) |
Jenkins build failure is a Jenkins issue, not something here. |
@kyledrake @victorbjelkholm @lgierth it looks like this is good to go except for the Jenkins fail, which if I remember right is an unrelated issue. Can I merge? (Checking with you because you've been involved in the history of this issue, and I'm a newcomer.) |
@lgierth @kyledrake @victorbjelkholm Can someone review this? It seems like a nice intro for new users who may not have a clear idea of what's IPFS about. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some super minor copy suggestions, but in general THIS SHOULD GO IN 👍 👍 ✨ 🎷 🐩
@Mr0grog if you have any feels about the copy changes then let me know. If I don't hear from you I'll merge this PR tomorrow and make some tweaks in a seperate PR. |
Co-Authored-By: Mr0grog <rob@robbrackett.com>
Co-Authored-By: Mr0grog <rob@robbrackett.com>
Co-Authored-By: Mr0grog <rob@robbrackett.com>
Those are all 100% excellent improvements, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very much needed intro doc ❤️ , can we merge this?
Ok, working on section two has been a bit slower than I hoped, so I’m pushing up this stuff as its own PR so people can start giving feedback now.
Is this too basic? Too much lecturing before we get to stuff you can actually do on your computer? Not enough? Does it strike the right tone and cover the right things?
I’ve also added a really minimal skeleton of concept docs so people can start to fill them in.
For the most part, I’m trying not to worry too much about layout or how this fits into the navigation yet. Feedback on that is good, too, but I wasn’t attempting to make it nice for this PR.
@lgierth / @kyledrake I wasn’t sure on the right way to modify the theme since the git repo mentioned in the them file doesn’t exist. Did it get (re)moved? What are we thinking for this?