Skip to content
This repository has been archived by the owner on Jun 2, 2020. It is now read-only.

Add section one (What is IPFS?) of new intro doc #67

Merged
merged 5 commits into from
Dec 15, 2018

Conversation

Mr0grog
Copy link
Collaborator

@Mr0grog Mr0grog commented Apr 14, 2018

Ok, working on section two has been a bit slower than I hoped, so I’m pushing up this stuff as its own PR so people can start giving feedback now.

Is this too basic? Too much lecturing before we get to stuff you can actually do on your computer? Not enough? Does it strike the right tone and cover the right things?

I’ve also added a really minimal skeleton of concept docs so people can start to fill them in.

For the most part, I’m trying not to worry too much about layout or how this fits into the navigation yet. Feedback on that is good, too, but I wasn’t attempting to make it nice for this PR.

@lgierth / @kyledrake I wasn’t sure on the right way to modify the theme since the git repo mentioned in the them file doesn’t exist. Did it get (re)moved? What are we thinking for this?

@Mr0grog Mr0grog requested review from a user, kyledrake and victorb April 14, 2018 00:37
@Mr0grog Mr0grog self-assigned this Jun 11, 2018
@Mr0grog
Copy link
Collaborator Author

Mr0grog commented Jun 11, 2018

This needs to be re-built on top of #68. The docs here should land in the new “introduction” section.

Mr0grog added 2 commits August 7, 2018 17:07
This is a rewrite of 315ba71 that fits with the new site organization (which wasn't fully baked when this draft was originally written).

License: MIT
Signed-off-by: Rob Brackett <rob@robbrackett.com>
We didn't have our own documentation on hashes when this document was originally written. Now we do, so link to it!

License: MIT
Signed-off-by: Rob Brackett <rob@robbrackett.com>
@Mr0grog Mr0grog force-pushed the doc/add-intro-overview branch from 315ba71 to 0e5b04d Compare August 8, 2018 00:13
@Mr0grog
Copy link
Collaborator Author

Mr0grog commented Aug 8, 2018

Rewritten to build nicely on top of current master. (a lot has changed since this was originally written!)

@Mr0grog
Copy link
Collaborator Author

Mr0grog commented Aug 8, 2018

Jenkins build failure is a Jenkins issue, not something here.

@meiqimichelle
Copy link
Contributor

@kyledrake @victorbjelkholm @lgierth it looks like this is good to go except for the Jenkins fail, which if I remember right is an unrelated issue. Can I merge? (Checking with you because you've been involved in the history of this issue, and I'm a newcomer.)

@schomatis
Copy link
Contributor

@lgierth @kyledrake @victorbjelkholm Can someone review this? It seems like a nice intro for new users who may not have a clear idea of what's IPFS about.

Copy link
Contributor

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some super minor copy suggestions, but in general THIS SHOULD GO IN 👍 👍 ✨ 🎷 🐩

content/introduction/overview.md Outdated Show resolved Hide resolved
content/introduction/overview.md Outdated Show resolved Hide resolved
content/introduction/overview.md Outdated Show resolved Hide resolved
@olizilla
Copy link
Contributor

olizilla commented Dec 3, 2018

@Mr0grog if you have any feels about the copy changes then let me know. If I don't hear from you I'll merge this PR tomorrow and make some tweaks in a seperate PR.

Co-Authored-By: Mr0grog <rob@robbrackett.com>
@ghost ghost added the in progress label Dec 3, 2018
olizilla and others added 2 commits December 3, 2018 15:01
Co-Authored-By: Mr0grog <rob@robbrackett.com>
Co-Authored-By: Mr0grog <rob@robbrackett.com>
@Mr0grog
Copy link
Collaborator Author

Mr0grog commented Dec 3, 2018

Those are all 100% excellent improvements, thank you!

Copy link
Contributor

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very much needed intro doc ❤️ , can we merge this?

@schomatis
Copy link
Contributor

This is a very much needed intro doc , can we merge this?

Yeeeess!! Thanks @Mr0grog and @olizilla 👍

@schomatis schomatis merged commit 2f8d0c2 into master Dec 15, 2018
@ghost ghost removed the in progress label Dec 15, 2018
@schomatis schomatis deleted the doc/add-intro-overview branch December 15, 2018 23:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants