Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Move the API specs into the Specs repo #11

Closed
daviddias opened this issue Dec 10, 2015 · 14 comments
Closed

Move the API specs into the Specs repo #11

daviddias opened this issue Dec 10, 2015 · 14 comments

Comments

@daviddias
Copy link
Contributor

I'm wondering if there is any particular reason why this specs aren't on the Specs repo

@jbenet
Copy link
Contributor

jbenet commented Dec 10, 2015

@diasdavid hmm good point. not sure, maybe because we made this repo with the intent to have the api live here? we can probably move stuff over to specs if you think it wold help to keep it all there

@jbenet
Copy link
Contributor

jbenet commented Dec 10, 2015

yeah probably makes sense

@dignifiedquire
Copy link
Collaborator

I suggest moving the apiary spec from https://github.com/dignifiedquire/ipfs-http-api to here, and the spec documents into the specs repo

@jbenet
Copy link
Contributor

jbenet commented Dec 10, 2015

Sgtm
On Thu, Dec 10, 2015 at 05:18 Friedel Ziegelmayer notifications@github.com
wrote:

I suggest moving the apiary spec from
https://github.com/dignifiedquire/ipfs-http-api to here, and the spec
documents into the specs repo


Reply to this email directly or view it on GitHub
#11 (comment).

@RichardLitt
Copy link
Contributor

Sounds good to me, too. 👍 Happy to do this later today.

@daviddias
Copy link
Contributor Author

Thank you :) Having specs on the specs repo helps for coordination (tagging PR and issues with its respective part of the system, so that others can tag along)

RichardLitt added a commit that referenced this issue Dec 11, 2015
The Readme Dignifiedquire/ipfs-http-api is empty, and the license is MIT, which
I am not sure we are going with here.

This move is in reference to #11.
RichardLitt added a commit to ipfs/specs that referenced this issue Dec 11, 2015
This is in reference to ipfs-inactive/http-api-spec#11. Thanks @diasdavid for the suggestion.
RichardLitt added a commit that referenced this issue Dec 11, 2015
The Readme Dignifiedquire/ipfs-http-api is empty, and the license is MIT, which
I am not sure we are going with here.

This move is in reference to #11.
@dignifiedquire
Copy link
Collaborator

@RichardLitt I changed the apiary settings to pull from this repo

@daviddias
Copy link
Contributor Author

@dignifiedquire would it be possible for it to pull from ipfs/specs so that we have all the specs there?

@dignifiedquire
Copy link
Collaborator

@diasdavid it would but that would mean the file has to be in the top level and you can't nest it.

@daviddias
Copy link
Contributor Author

@dignifiedquire just one file right? I would be comfortable with that. Maybe we can contact support from Apiary to see if they would be open to add nesting as a feature

@RichardLitt
Copy link
Contributor

Well, it may be smart to have both; the spec API, also listed in .apib, and then the actual API, which could be listed here as functions that we know are currently available. This would solve some issues, like #14. This would allow us to look at specs when we want to know how the API should look, and to compare the two. The only real issue I can foresee with this is when we want to change both specs and the api here, but I don't think that's something that can be avoided.

What do you think? I'll contact Apiary about nesting as a feature, if this sounds good.

@daviddias
Copy link
Contributor Author

Having both sounds good :) Let's move it to the specs repo :D

@dborzov found that you had invested some energy on documenting the CLI API as well (ipfs/kubo#785), wanna help us finish this endeavour, having the API spec'ed out will be incredibly helpful for everyone consuming IPFS with clients or simply building the client libraries (like js-ipfs-api)

@daviddias daviddias changed the title API Spec => Specs Repo Move the API specs into the Specs repo Jan 10, 2016
@daviddias
Copy link
Contributor Author

Apparently was done on:

0988505

Thank you @RichardLitt

@RichardLitt
Copy link
Contributor

Yep. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants