This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Added Group commands
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is "Group |
Should be a GET, although the API will take anything (for now) |
|
Ok. In that case, let's just wait on #2301 to see how this goes. |
|
LGTM |
|
@whyrusleeping What is going on with ShowOptions? |
|
Seems like the only blocker here is a bug on go-ipfs ipfs/kubo#2301 I recommend to merge the PR as it is and leave that option to be filled later (officially, the API doesn't support that flag anyway) |
Two bugs: - [ ] I am not sure if this is a `get` request or not. - [ ] The `flag` option switches ShowOptions to true, but the option objects remain empty.
RichardLitt
force-pushed
the
feature/commands
branch
from
6bdc5e5 to
7c29cf4
Compare
|
Removed the flag option. We can readd it when #2301 is closed, if the API needs it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugs:
getrequest or not.flagoption switches ShowOptions to true, but the option objects remain empty.