This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Added group name
#47
Merged
Added group name
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardLitt
force-pushed
the
feature/name
branch
2 times, most recently
from
fe61189
to
6932ab1
Compare
| @@ -1661,9 +1661,261 @@ root will not be listable, as it is virtual. Access known paths directly. | |||
|
|
|||
| # Group name | |||
|
|
|||
| ## publish | |||
| IPFS namespace (IPNS) tool | |||
There was a problem hiding this comment.
Link to ipns spec/description/docs would be good
There was a problem hiding this comment.
Not sure about that. I'd rather not add links which aren't part of the CLI mans.
RichardLitt
force-pushed
the
feature/name
branch
from
6932ab1
to
8458829
Compare
|
@dignifiedquire added a |
RichardLitt
force-pushed
the
feature/name
branch
2 times, most recently
from
f1d026b
to
6538ebb
Compare
I was unable to get an argument working with resolve. That should work.
RichardLitt
force-pushed
the
feature/name
branch
from
30254cd
to
fadc25d
Compare
|
Note that |
| time formats can be joined. For example, '3h30m'. | ||
|
|
||
| + (string) - The time format, composed of a number followed by an enumerated list with the following members. | ||
| + Members |
There was a problem hiding this comment.
If it's not an enum Members is wrong afaik.
There was a problem hiding this comment.
Not sure how else to do this. Just a text description?
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to get an argument working with resolve. That should work.