This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Added Group pin
#48
Merged
Added Group pin
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ## ls | ||
| ## add [GET /pin/add{?arg}{&recursive}] | ||
| Pins objects to local storage |
RichardLitt
force-pushed
the
feature/pin
branch
from
cdd1822
to
e46050f
Compare
I am not sure about ls count. I do not think that ls --quiet is an argument: the go code is a flag for Fprintf or not, which makes me think it does not affect the API returns. But I cannot tell, because in Wireshark it is all sent as flags.
|
@whyrusleeping Note @dignifiedquire's comments in the outdated diffs. Some of the flags don't seem to work on the API. |
|
Before merging, this needs to be updated to reflect changes in https://github.com/ipfs/go-ipfs/pull/2477/files. |
|
@RichardLitt ipfs/kubo#2477 was merged. Can we merge this one now? |
|
Merged! |
|
wooo :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure about ls count. I do not think that ls --quiet is an argument: the go code is a flag for Fprintf or not, which makes me think it does not affect the API returns. But I cannot tell, because in Wireshark it is all sent as flags.