MFS ipfs.files.cp arguments

[achingbrain]

What's the thinking behind the ipfs.files.cp arguments? Specifically why is the first argument an array?

ipfs.files.cp([sourceFile, destinationFile], callback)

It could be more straightforward as:

ipfs.files.cp(sourceFile, destinationFile, callback)

I suppose maybe you'd want to imitate the unix cp command and support both the above and:

ipfs.files.cp(...sourceFiles, destinationDirectory, callback)

Obviously JavaScript doesn't support left-variadic functions so you'd have to emulate it by interrogating arguments but that's an implementation detail.

[alanshaw]

I'm +1 on removing the single array argument in favour of two arguments unless there's a good reason for it. @diasdavid what do you think?

It's also super confusing in the docs right now because we use square brackets to denote an optional arg.

N.B. files.mv has the same API

[daviddias]

👍 on removing the array proposal too.

[achingbrain]

Great, I'll put a PR together tomorrow.

[achingbrain]

See #277 for more on this.