This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
test: add test for ipfs.pubsub.publish with a binary (non-utf8) buffer #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for catching this and coming up with a solution, @vith! Really appreciate it :) Mind fixing the linting for clean merge? |
daviddias
suggested changes
Jun 21, 2017
src/pubsub.js
Outdated
| expect(msg.data.toString('hex')).to.be.eql(expectedHex) | ||
| expect(msg.from).to.be.eql(ipfs2.peerId.id) | ||
| check() | ||
| } catch (e) { |
There was a problem hiding this comment.
use err so that standard can catch if missing
src/pubsub.js
Outdated
| expect(msg.data.toString('hex')).to.be.eql(expectedHex) | ||
| expect(msg.from).to.be.eql(ipfs2.peerId.id) | ||
| check() | ||
| } catch (e) { |
There was a problem hiding this comment.
use err so that standard can catch if missing
src/pubsub.js
Outdated
| series([ | ||
| (cb) => ipfs1.pubsub.subscribe(topic, sub1, cb), | ||
| (cb) => ipfs2.pubsub.subscribe(topic, sub2, cb), | ||
| (cb) => waitForPeers(ipfs2, topic, [ipfs1.peerId.id], cb), |
|
Apologies, didn't realize my eslint editor integration wasn't working. Is that better? |
daviddias
approved these changes
Jun 21, 2017
|
perfect, thank you @vith! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently fails in js-ipfs-api.
issue: ipfs-inactive/js-ipfs-http-client#569
fix PR: ipfs-inactive/js-ipfs-http-client#570