Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

generic API #33

Merged
merged 2 commits into from
Aug 16, 2016
Merged

generic API #33

merged 2 commits into from
Aug 16, 2016

Conversation

daviddias
Copy link
Contributor

@daviddias daviddias commented Jun 28, 2016

WIP

  • spec
    • id
    • version
  • works on js-ipfs
  • works on js-ipfs-api

@daviddias
Copy link
Contributor Author

@nginnever any update on this one? Thank you :)

@@ -2,7 +2,7 @@
"name": "interface-ipfs-core",
"version": "0.9.0",
"description": "A test suite and interface you can use to implement a IPFS core interface.",
"main": "lib/index.js",
"main": "src/index.js",
Copy link
Contributor Author

@daviddias daviddias Aug 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • change this before merge and release

@@ -0,0 +1,48 @@
generic API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calitalize

@daviddias daviddias merged commit e595684 into master Aug 16, 2016
@daviddias daviddias deleted the generic-api branch August 16, 2016 14:26
##### `JavaScript` - ipfs.id([callback])

`callback` must follow `function (err, identity) {}` signature, where `err` is an error if the operation was not successful. `identity` is an object with the Peer identity.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add an example to show what "Peer identity" means? Ie. the data that is returned.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants