This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix(ci): avoid fs clash during ipfs.add* on Windows #523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes random TravisCI failures on Windows and unblocks ipfs/js-ipfs#2304
Root cause
Windows issue was triggered by parallel
ipfs.add*
of the same data:Both
addFromURL
andadd
added the same data, touched same files on filesystem, triggering a known problem with Node on Windows and Travis:Fix
One way to fix this type of error is to run as Windows Administrator. It does not seem to be feasible for TravisCI.
Instead, switching to sequential mode of operation removes
addFromURL
tests as a surface for file system race conditions on Windows.