This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
feat: add support for async/await setup in the swarm tests #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
reviewed
Sep 16, 2019
src/miscellaneous/id.js
Outdated
| @@ -8,13 +8,13 @@ module.exports = (createCommon, options) => { | |||
| const it = getIt(options) | |||
| const common = createCommon() | |||
|
|
|||
| describe('.id', () => { | |||
| describe('.id', function () { | |||
| this.timeout(60 * 1000) | |||
| let ipfs | |||
|
|
|||
| before(function (done) { | |||
| // CI takes longer to instantiate the daemon, so we need to increase the | |||
| // timeout for the before step | |||
There was a problem hiding this comment.
This comment can probably go if we're removing the this.timeout
hugomrdias
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases a couples of timeout and adds support for async/await setup in the swarm tests
More PRs will follow to move everything to async/await setup
the following PRs add support async setup:
ipfs-inactive/js-ipfs-http-client#1105
ipfs/js-ipfs#2428