Merge pull request #221 from xicombd/config-set-flags

Auto set json and bool flags on config.set

src/api/config.js

@@ -10,6 +10,15 @@ module.exports = (send) => {
         cb = opts
         opts = {}
       }
+
+      if (typeof (value) === 'object') {
+        value = JSON.stringify(value)
+        opts = { json: true }
+      } else if (typeof (value) === 'boolean') {
+        value = value.toString()
+        opts = { bool: true }
+      }
+
       return send('config', [key, value], opts, null, cb)
     },
     show (cb) {

test/api/config.spec.js

@@ -3,16 +3,46 @@
 const path = require('path')
 
 describe('.config', () => {
-  it('.config.{set, get}', (done) => {
-    const confKey = 'arbitraryKey'
-    const confVal = 'arbitraryVal'
+  describe('.config.{set, get}', () => {
+    it('string', (done) => {
+      const confKey = 'arbitraryKey'
+      const confVal = 'arbitraryVal'
 
-    apiClients['a'].config.set(confKey, confVal, (err, res) => {
-      expect(err).to.not.exist
-      apiClients['a'].config.get(confKey, (err, res) => {
+      apiClients['a'].config.set(confKey, confVal, (err, res) => {
+        expect(err).to.not.exist
+        apiClients['a'].config.get(confKey, (err, res) => {
+          expect(err).to.not.exist
+          expect(res).to.have.a.property('Value', confVal)
+          done()
+        })
+      })
+    })
+
+    it('bool', (done) => {
+      const confKey = 'otherKey'
+      const confVal = true
+
+      apiClients['a'].config.set(confKey, confVal, (err, res) => {
         expect(err).to.not.exist
-        expect(res).to.have.a.property('Value', confVal)
-        done()
+        apiClients['a'].config.get(confKey, (err, res) => {
+          expect(err).to.not.exist
+          expect(res.Value).to.deep.equal(confVal)
+          done()
+        })
+      })
+    })
+
+    it('json', (done) => {
+      const confKey = 'API.HTTPHeaders.Access-Control-Allow-Origin'
+      const confVal = ['http://example.io']
+
+      apiClients['a'].config.set(confKey, confVal, (err, res) => {
+        expect(err).to.not.exist
+        apiClients['a'].config.get(confKey, (err, res) => {
+          expect(err).to.not.exist
+          expect(res.Value).to.deep.equal(confVal)
+          done()
+        })
       })
     })
   })
@@ -38,17 +68,45 @@ describe('.config', () => {
   })
 
   describe('promise', () => {
-    it('.config.{set, get}', () => {
-      const confKey = 'arbitraryKey'
-      const confVal = 'arbitraryVal'
+    describe('.config.{set, get}', () => {
+      it('string', () => {
+        const confKey = 'arbitraryKey'
+        const confVal = 'arbitraryVal'
 
-      return apiClients['a'].config.set(confKey, confVal)
-        .then((res) => {
-          return apiClients['a'].config.get(confKey)
-        })
-        .then((res) => {
-          expect(res).to.have.a.property('Value', confVal)
-        })
+        return apiClients['a'].config.set(confKey, confVal)
+          .then((res) => {
+            return apiClients['a'].config.get(confKey)
+          })
+          .then((res) => {
+            expect(res).to.have.a.property('Value', confVal)
+          })
+      })
+
+      it('bool', () => {
+        const confKey = 'otherKey'
+        const confVal = true
+
+        return apiClients['a'].config.set(confKey, confVal)
+          .then((res) => {
+            return apiClients['a'].config.get(confKey)
+          })
+          .then((res) => {
+            expect(res.Value).to.deep.equal(confVal)
+          })
+      })
+
+      it('json', () => {
+        const confKey = 'API.HTTPHeaders.Access-Control-Allow-Origin'
+        const confVal = ['http://example.com']
+
+        return apiClients['a'].config.set(confKey, confVal)
+          .then((res) => {
+            return apiClients['a'].config.get(confKey)
+          })
+          .then((res) => {
+            expect(res.Value).to.deep.equal(confVal)
+          })
+      })
     })
 
     it('.config.show', () => {