Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

ipfs object patch api clunky? #141

Closed
jbenet opened this issue Nov 23, 2015 · 4 comments
Closed

ipfs object patch api clunky? #141

jbenet opened this issue Nov 23, 2015 · 4 comments

Comments

@jbenet
Copy link
Contributor

jbenet commented Nov 23, 2015

i would expect either:

ipfs.object.patch(root, 'add-link', name, hash, cb)
ipfs.object.patch([root, 'add-link', name, hash], cb)

// but not (current)
ipfs.object.patch(root, ['add-link', name, hash], cb)
@dignifiedquire
Copy link
Contributor

I think it should be the first one ipfs.object.patch(root, 'add-link', name, hash, cb)

@daviddias
Copy link
Contributor

daviddias commented Apr 17, 2016

Let's get that core spec done, so that js-ipfs-api can follow it too :)

@daviddias
Copy link
Contributor

daviddias commented May 11, 2016

@jbenet well, you know...a way to get it less clunky is.. ipfs/js-ipfs#110 :D

@daviddias
Copy link
Contributor

Now, interface-ipfs-core and the Object API spec exists. The implementation on js-ipfs-api updated to conform with it.

It shouldn't be 'clunky' anymore. Closing this issue, feedback is welcome on the interface-ipfs-core repo, see the API here:

https://github.com/ipfs/interface-ipfs-core/tree/master/API/object

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants