Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

createAddStream implementation buffers instead of streaming #628

Closed
pgte opened this issue Nov 15, 2017 · 0 comments · Fixed by #629
Closed

createAddStream implementation buffers instead of streaming #628

pgte opened this issue Nov 15, 2017 · 0 comments · Fixed by #629
Assignees
@pgte
Labels
bug P1 - High

Comments

@pgte
Copy link
Contributor

pgte commented Nov 15, 2017 •
edited
Loading

ipfs.createAddStrean does not stream. Instead, if buffers all the files with open readable streams, which can eventually lead to file descriptor exhaustion.

Symptom well described in: ipfs/js-ipfs#823
@pgte pgte mentioned this issue Nov 15, 2017
Closed
@pgte pgte changed the title add implementation does not stream createAddStream implementation buffers instead of streaming Nov 15, 2017
@pgte pgte self-assigned this Nov 15, 2017
@pgte pgte mentioned this issue Nov 17, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pgte pgte

Labels
bug P1 - High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

send files HTTP request should stream ipfs-inactive/js-ipfs-http-client
2 participants
@pgte @daviddias