-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ENFILE when daemon is on #823
Comments
I can confirm this issue. The problem is that, in my machine, when I try to add a small directory (e.g.
Can someone reproduce it as well? Or there is something wrong with my configuration of js-ipfs? I am noting that my ulimit is 256 (default in macOS Sierra). |
I haven't checked, but I think the problem is that the builder is trying to put ALL files into the store at once. We can probably fix this by using The ulimit on MacOS seems to be the strictest (256) so limit to 64? |
This issue only happens when the daemon is on and on the side of the CLI, when the daemon is off (meaning directly to code-> builder) it works fine. The real issue is coming from https://github.com/ipfs/js-ipfs/blob/master/src/cli/commands/files/add.js trying to buffer everything to create the multipart message instead of streaming it. |
This happens because the current |
Fix is coming ipfs-inactive/js-ipfs-http-client#629 thanks @pgte :) |
@pgte has successfully fixed this with ipfs-inactive/js-ipfs-http-client#629 \o/ |
I started seeing a
ENFILE
error when adding large directories with the daemon on. This is we are trying to open all the files to then send them through js-ipfs-api -- https://github.com/ipfs/js-ipfs/blob/master/src/cli/commands/files/add.js --.Note that I have my ulimit already increased by default and not using Mac OS X default.
This can be reproduced by simply adding the
node_modules
folder from js-ipfs.The text was updated successfully, but these errors were encountered: