Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Update multiaddr to the latest version 🚀 #1136

Merged
merged 2 commits into from
Nov 5, 2019

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Oct 28, 2019

The dependency multiaddr was updated from 6.1.1 to 7.2.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: jacobheun
License: MIT

Release Notes for v7.2.0

Features

Commits

The new version differs by 13 commits ahead by 13, behind by 3.

  • 4039f38 chore: release version v7.2.0
  • 8d9192b chore: update contributors
  • eead174 feat: support Peer ID represented as CID (#102)
  • 43cb934 docs(fix): fromNodeAddress take an object (#100)
  • 3bcb6d2 chore: release version v7.1.0
  • 522edfe chore: update contributors
  • 19a3940 feat: add decapsulateCode method (#98)
  • 3681086 chore: release version v7.0.0
  • e3e93cf chore: update contributors
  • 46f257a refactor: default 421 to use p2p by default instead of ipfs (#97)
  • 371dc47 refactor: use async instead of callbacks (#96)
  • c32071d fix: make getPeerId resolve the last id (#95)
  • 2a170c3 fix: return ports as ints not strings (#87)

See the full diff


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@alanshaw alanshaw merged commit 9b1589c into master Nov 5, 2019
@alanshaw alanshaw deleted the greenkeeper/multiaddr-7.2.0 branch November 5, 2019 12:16
@achingbrain
Copy link
Collaborator

achingbrain commented Nov 5, 2019

Please revert this - we cannot upgrade multiaddr until libp2p does.

See:

#1102
multiformats/js-mafmt#44
libp2p/js-peer-info#81

@alanshaw
Copy link
Contributor

alanshaw commented Nov 5, 2019

Shouldn't we fix mafmt to use proto codes not names or where there other issues?

@achingbrain
Copy link
Collaborator

There were problems with dialling peers and likely other stuff but I gave up trying to fix it because it became obvious that there are a lot of moving pieces to change, some of which are already being refactored.

Better to wait for libp2p to be upgraded, then upgrade all the IPFS libs. TBH other than appeasing greenkeeper the upgrade itself doesn't give us much.

This sort of dependency hell issue would be made more visible by ipfs/js-ipfs#2446 because we'd do the upgrade for this and js-IPFS in one PR, the build for which would fail because libp2p needs upgrading too.

alanshaw pushed a commit that referenced this pull request Nov 5, 2019
This reverts commit 9b1589c.

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw pushed a commit that referenced this pull request Nov 6, 2019
This reverts commit 9b1589c.

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants