Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

fix: return iterables from pin add and pin rm #1240

Closed
wants to merge 5 commits into from
Closed

fix: return iterables from pin add and pin rm #1240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6c4c19
fix: return iterables from pin add and pin rm
achingbrain Feb 17, 2020
56a1705
fix: rename arg
achingbrain Feb 17, 2020
97c4484
chore: pin go dep version
achingbrain Feb 17, 2020
88b659b
chore: use specific commit
achingbrain Feb 17, 2020
277585b
chore: remove whitespace
achingbrain Feb 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@
"aegir": "^20.4.1",
"async": "^3.1.0",
"browser-process-platform": "~0.1.1",
"go-ipfs-dep": "^0.4.23-3",
"interface-ipfs-core": "^0.131.7",
"go-ipfs-dep": "0.4.23-3",
"interface-ipfs-core": "github:ipfs/interface-js-ipfs-core#store-pins-in-datastore",
"ipfsd-ctl": "^3.0.0",
"it-all": "^1.0.1",
"it-concat": "^1.0.0",
Expand Down
4 changes: 2 additions & 2 deletions src/pin/add.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const CID = require('cids')
const configure = require('../lib/configure')

module.exports = configure(({ ky }) => {
return async (paths, options) => {
return async function * (paths, options) {
paths = Array.isArray(paths) ? paths : [paths]
options = options || {}

Expand All @@ -19,6 +19,6 @@ module.exports = configure(({ ky }) => {
searchParams
}).json()

return (res.Pins || []).map(cid => ({ cid: new CID(cid) }))
yield * (res.Pins || []).map(cid => ({ cid: new CID(cid) }))
}
})
7 changes: 4 additions & 3 deletions src/pin/rm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@ const CID = require('cids')
const configure = require('../lib/configure')

module.exports = configure(({ ky }) => {
return async (path, options) => {
return async function * (paths, options) {
paths = Array.isArray(paths) ? paths : [paths]
options = options || {}

const searchParams = new URLSearchParams(options.searchParams)
searchParams.set('arg', `${path}`)
paths.forEach(path => searchParams.append('arg', `${path}`))
if (options.recursive != null) searchParams.set('recursive', options.recursive)

const res = await ky.post('pin/rm', {
Expand All @@ -18,6 +19,6 @@ module.exports = configure(({ ky }) => {
searchParams
}).json()

return (res.Pins || []).map(cid => ({ cid: new CID(cid) }))
yield * (res.Pins || []).map(cid => ({ cid: new CID(cid) }))
}
})