This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Exclude port from path if config.port not set.
#162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks. could you add a test for this please? |
|
Of course. Tests added. |
| const opts = { | ||
| method: files ? 'POST' : 'GET', | ||
| uri: `${config.protocol}://${config.host}:${config.port}${config['api-path']}${path}?${Qs.stringify(qs, {arrayFormat: 'repeat'})}`, | ||
| uri: `${config.protocol}://${config.host}${port}${config['api-path']}${path}?${Qs.stringify(qs, {arrayFormat: 'repeat'})}`, |
There was a problem hiding this comment.
Handling this with the url module is probably best. It cleans up that template a lot. Not a huge issue though.
let uri = url.format({
protocol: config.protocol,
hostname: config.host,
port: config.port,
pathname: `${config['api-path']}/${path}`.replace(/\/+/g, '/'), // Double slashes don't matter, but it looks nicer.
query: qs
})It will handle the undefined port and not include it.
daviddias
added a commit
that referenced
this pull request
Dec 19, 2015
Exclude port from path if `config.port` not set.
|
Nice, thanks. cc @jacksenechal. |
|
Thank you for fixing this and adding the test :):) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161.