This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Avoid crash for responses without 'content-type' header #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we have a test for this? |
fbaiodias
force-pushed
the
fix-content-type
branch
from
ac10343 to
c7b2d86
Compare
|
AFAIK |
|
@xicombd LGTM, but since it is such a odd looking test, could you add 2 lines of code comments explaining why that test exists, otherwise it might get quickly deleted by someone in the future |
fbaiodias
force-pushed
the
fix-content-type
branch
from
c7b2d86 to
e295e8f
Compare
|
@diasdavid added the the comments |
daviddias
added a commit
that referenced
this pull request
Mar 1, 2016
Avoid crash for responses without 'content-type' header
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, when the response is a 200 OK without body