Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

[WIP] Replacing wreck with fetch #355

Closed
wants to merge 5 commits into from
Closed

[WIP] Replacing wreck with fetch #355

wants to merge 5 commits into from

Conversation

dignifiedquire
Copy link
Contributor

@dignifiedquire dignifiedquire commented Aug 23, 2016

As discussed in #353 this can help us reduce the size of the bundle.

  • Reenable browser tests on CI
  • Get browser tests to run without memory flag
  • Tests passing in node
  • Tests passing in phantomjs
  • Tests passing in Chrome
  • Figure out log tests (passing before, but shouldn't have)

@dignifiedquire dignifiedquire changed the title Replacing wreck with fetch [WIP] Replacing wreck with fetch Aug 23, 2016
@daviddias
Copy link
Contributor

Circle is still not happy, seems that you managed to reduce the memory fingerprint, but not totally:

<--- Last few GCs --->

   97037 ms: Mark-sweep 1346.4 (1422.4) -> 1346.0 (1423.4) MB, 172.9 / 0 ms (+ 5.6 ms in 42 steps since start of marking, biggest step 1.7 ms) [allocation failure] [GC in old space requested].
   97220 ms: Mark-sweep 1346.0 (1423.4) -> 1346.0 (1424.4) MB, 182.1 / 0 ms [allocation failure] [GC in old space requested].
   97444 ms: Mark-sweep 1346.0 (1424.4) -> 1346.0 (1418.4) MB, 224.2 / 0 ms [last resort gc].
   97641 ms: Mark-sweep 1346.0 (1418.4) -> 1345.9 (1414.4) MB, 197.2 / 0 ms [last resort gc].


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x16cfd8ac9e31 <JS Object>
    1: slowToString [buffer.js:467] [pc=0x35bbcf78bb75] (this=0x93d6d983831 <an Uint8Array with map 0x54321fb34a1>,encoding=0x93d6d983711 <String[5]: utf-8>,start=0,end=22984396)
    2: arguments adaptor frame: 1->3
    3: toString [buffer.js:~495] [pc=0x35bbcf768f03] (this=0x93d6d983831 <an Uint8Array with map 0x54321fb34a1>)
    4: arguments adaptor frame: 1->0
    5: inlineMap [/home/ubuntu/...

describe('.log', () => {
// How did this work before
// our polyfill didn't have real streaming support
describe.skip('.log', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polyfill? That is why we have the if(!isPhantom)

@dignifiedquire
Copy link
Contributor Author

Real streaming is working in Node.js and Chrome. For other browsers I need to implement a fallback onto xhr based streaming.

@dignifiedquire
Copy link
Contributor Author

Replaced by #414

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants