This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Implement dag.get #549
Closed
Implement dag.get #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @magik6k thank you for PR'ing this. It is a bit more complex than it seems as the DAG API needs to support multiple formats and not just protobufs. I started the work here: #534 but it will require some updates on go-ipfs as well. Would you like to help land both changes in js and go land? Let's keep chatting over #534 , closing this one. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
dag.getfor #534. Arguments should behave exactly as in js-ipfs.