This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned daviddias
Oct 30, 2017
ghost
added
the
in progress
label
Oct 30, 2017
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
==========================================
+ Coverage 83.6% 83.86% +0.26%
==========================================
Files 105 112 +7
Lines 1464 1624 +160
==========================================
+ Hits 1224 1362 +138
- Misses 240 262 +22
Continue to review full report at Codecov.
|
daviddias
force-pushed
the
new-streaming-interface
branch
from
November 14, 2017 09:52
989d71f
to
9141594
Compare
daviddias
force-pushed
the
new-streaming-interface
branch
from
November 17, 2017 10:54
1587b32
to
3bfdea2
Compare
I'm confident with this PR and I went to merge it with ipfs-inactive/interface-js-ipfs-core#162. Can I get CR from someone? |
daviddias
requested review from
dignifiedquire,
pgte,
hacdias,
flyingzumwalt,
alanshaw and
olizilla
and removed request for
flyingzumwalt
November 17, 2017 17:35
63 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: ipfs-inactive/interface-js-ipfs-core#162