Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Implementing the new interfaces #619

Merged
merged 19 commits into from
Nov 17, 2017
Merged

Implementing the new interfaces #619

merged 19 commits into from
Nov 17, 2017

Conversation

daviddias
Copy link
Contributor

@ghost ghost assigned daviddias Oct 30, 2017
@ghost ghost added the in progress label Oct 30, 2017
@codecov
Copy link

codecov bot commented Oct 31, 2017

Codecov Report

Merging #619 into master will increase coverage by 0.26%.
The diff coverage is 88.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
+ Coverage    83.6%   83.86%   +0.26%     
==========================================
  Files         105      112       +7     
  Lines        1464     1624     +160     
==========================================
+ Hits         1224     1362     +138     
- Misses        240      262      +22
Impacted Files Coverage Δ
src/utils/load-commands.js 100% <ø> (ø) ⬆️
src/files/index.js 100% <ø> (ø) ⬆️
src/files/add-pull-stream.js 100% <100%> (ø)
src/files/add-readable-stream.js 100% <100%> (ø)
src/files/cat.js 100% <100%> (ø) ⬆️
src/files/get.js 93.1% <100%> (+4.21%) ⬆️
src/ls-pull-stream.js 75.86% <75.86%> (ø)
src/ls-readable-stream.js 78.57% <78.57%> (ø)
src/files/cat-pull-stream.js 87.5% <87.5%> (ø)
src/files/cat-readable-stream.js 87.5% <87.5%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e389171...971c12c. Read the comment docs.

@daviddias
Copy link
Contributor Author

I'm confident with this PR and I went to merge it with ipfs-inactive/interface-js-ipfs-core#162. Can I get CR from someone?

@daviddias
Copy link
Contributor Author

daviddias commented Nov 17, 2017

@pgte will your PR -- #629 --fix the outstanding issues here (only visible in CI) ?

Edit: It was the old go-ipfs issue

@daviddias daviddias merged commit e1b38bf into master Nov 17, 2017
@daviddias daviddias deleted the new-streaming-interface branch November 17, 2017 19:52
@ghost ghost removed the in progress label Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant