Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

feat: use new ipfsd-ctl #652

Closed
wants to merge 8 commits into from
Closed

feat: use new ipfsd-ctl #652

wants to merge 8 commits into from

Conversation

dryajov
Copy link
Contributor

@dryajov dryajov commented Dec 21, 2017

No description provided.

expect(err).to.not.exist()
ipfs = node
ipfsd = node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace this line by: ipfs = ipfsd.api and avoid replacing all the other lines.

@daviddias
Copy link
Contributor

I've pulled the latest and did all the linking and I get an error:

  1) .swarm
       callback API
         .addrs:
     Uncaught Error: no protocol with name: dnsaddr
      at Protocols (/Users/imp/code/js-ipfsd-ctl/node_modules/multiaddr/src/protocols-table.js:17:11)
      at stringToStringTuples (/Users/imp/code/js-ipfsd-ctl/node_modules/multiaddr/src/codec.js:45:19)
      at stringToBuffer (/Users/imp/code/js-ipfsd-ctl/node_modules/multiaddr/src/codec.js:170:13)
      at Object.fromString (/Users/imp/code/js-ipfsd-ctl/node_modules/multiaddr/src/codec.js:178:10)
      at new Multiaddr (/Users/imp/code/js-ipfsd-ctl/node_modules/multiaddr/src/index.js:39:25)
      at Multiaddr (/Users/imp/code/js-ipfsd-ctl/node_modules/multiaddr/src/index.js:27:12)
      at result.Addrs.(anonymous function).forEach (/Users/imp/code/js-ipfsd-ctl/node_modules/ipfs-api/src/swarm/addrs.js:25:35)
      at Array.forEach (<anonymous>)
      at Object.keys.map (/Users/imp/code/js-ipfsd-ctl/node_modules/ipfs-api/src/swarm/addrs.js:24:26)
      at Array.map (<anonymous>)
      at send (/Users/imp/code/js-ipfsd-ctl/node_modules/ipfs-api/src/swarm/addrs.js:22:47)
      at f (/Users/imp/code/js-ipfsd-ctl/node_modules/once/once.js:25:25)
      at streamToValue (/Users/imp/code/js-ipfsd-ctl/node_modules/ipfs-api/src/utils/stream-to-json-value.js:30:5)
      at concat (/Users/imp/code/js-ipfsd-ctl/node_modules/ipfs-api/src/utils/stream-to-value.js:12:22)
      at ConcatStream.<anonymous> (/Users/imp/code/js-ipfsd-ctl/node_modules/concat-stream/index.js:36:43)
      at finishMaybe (/Users/imp/code/js-ipfsd-ctl/node_modules/readable-stream/lib/_stream_writable.js:607:14)
      at endWritable (/Users/imp/code/js-ipfsd-ctl/node_modules/readable-stream/lib/_stream_writable.js:615:3)
      at ConcatStream.Writable.end (/Users/imp/code/js-ipfsd-ctl/node_modules/readable-stream/lib/_stream_writable.js:571:41)
      at IncomingMessage.onend (_stream_readable.js:595:10)
      at endReadableNT (_stream_readable.js:1056:12)
      at _combinedTickCallback (internal/process/next_tick.js:138:11)
      at process._tickDomainCallback (internal/process/next_tick.js:218:9)


@dryajov
Copy link
Contributor Author

dryajov commented Jan 5, 2018

@diasdavid based on my convo with lgierth on IRC, it seems like /dns/<addr> was renamed to /dnsaddr/<addr>, here is a PR that addresses it - multiformats/js-multiaddr#50.

@dryajov dryajov changed the title [WIP] feat: use new ipfsd-ctl feat: use new ipfsd-ctl Jan 15, 2018
@daviddias
Copy link
Contributor

ipfsd-ctl 0.27 has been published. Could you update the PR and rebase master to resolve merge conflicts?

@dryajov
Copy link
Contributor Author

dryajov commented Jan 16, 2018

depends on ipfs-inactive/interface-js-ipfs-core#186

@daviddias
Copy link
Contributor

image

@dryajov can you check why the Coveralls dropped so much?

@dryajov
Copy link
Contributor Author

dryajov commented Jan 19, 2018

@diasdavid not sure why coverage dropped so much, I see that some tests are failing which might be messing up the coverage report, but other than that the actual tests haven't been altered to cause such a drop. I'll keep investigating.

@daviddias
Copy link
Contributor

Just found out that my attempts to fix the last problem haven't been working because apparently, Github lost track of this branch and PR.

It thinks that feat/ipfsd-ctl doesn't have a PR associated yet:
image

@daviddias
Copy link
Contributor

closing this PR and opening again

@daviddias daviddias closed this Jan 19, 2018
@ghost ghost removed the in progress label Jan 19, 2018
@daviddias daviddias mentioned this pull request Jan 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants