Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

test: HTTP weirdness #656

Merged
merged 2 commits into from
Dec 30, 2017
Merged

test: HTTP weirdness #656

merged 2 commits into from
Dec 30, 2017

Conversation

richardschneider
Copy link
Contributor

First reported in #648

4) 'deal with HTTP weirdness' tests does not crash if no content-type header is provided:
     Uncaught AssertionError: expected [Error: read ECONNRESET] to not exist 
      at ipfsAPI.config.replace (test\request-api.spec.js:28:28)

This is just a work around and does not fix the underlying problem. I've changed the test to use id instead of config.replace and the test passes.

@diasdavid I'm think the ECONNRESET could be coming from push stream not being read by the server. But perhaps it something else. More eyeballs might help. I think it's more of a timing/race issue than a specific windows issue

@ghost ghost added the in progress label Dec 29, 2017
@richardschneider richardschneider changed the title [WIP} test: HTTP weirdness [WIP] test: HTTP weirdness Dec 29, 2017
@richardschneider
Copy link
Contributor Author

Fixed it by consuming the entire request, before responding.

@richardschneider richardschneider changed the title [WIP] test: HTTP weirdness test: HTTP weirdness Dec 29, 2017
@daviddias
Copy link
Contributor

Interesting, this looks like a Node.js issue and not a js-ipfs-api. Thanks @richardschneider

@daviddias daviddias changed the base branch from master to automatic-ci-script-update December 30, 2017 05:12
@daviddias daviddias changed the base branch from automatic-ci-script-update to master December 30, 2017 05:12
@daviddias daviddias merged commit 959e119 into master Dec 30, 2017
@daviddias daviddias deleted the no-content-type branch December 30, 2017 05:13
@ghost ghost removed the in progress label Dec 30, 2017
dryajov pushed a commit that referenced this pull request Jan 3, 2018
* test: a work around for HTTP weirdness

* test: consume the entire request, before responding
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants