This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: don't create one webpack bundle for every test file #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@vmx the latest |
dryajov
approved these changes
Mar 5, 2018
daviddias
approved these changes
Mar 6, 2018
daviddias
reviewed
Mar 7, 2018
package.json
Outdated
| @@ -65,15 +65,15 @@ | |||
| "url": "https://github.com/ipfs/js-ipfs-api" | |||
| }, | |||
| "devDependencies": { | |||
| "aegir": "^13.0.0", | |||
| "aegir": "https://github.com/ipfs/aegir#karma-webpack-bundle-alt2", | |||
There was a problem hiding this comment.
Can you release aegir and update it here?
There was a problem hiding this comment.
I'll do once I'm done with my Windows fixes.
There was a problem hiding this comment.
The ones I'm working on atm.
With the release of AEgir 13.0.6 it is no longer needed to increase the memory size, as there will be only a single webpack bundle for all tests, which takes little enough memory.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new experimental branch of AEgir which
should fix the issue with taking to much memory when running the
Browser based tests. If it turns out to be successful, there
will be a new AEgir release containing that fix.