This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Get CI Green #714
Closed
Get CI Green #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@vmx let's see what CI tells us now :) |
|
Some new test fails, but browser tests do run! :)
|
|
@vmx can you land the rest? |
|
@diasdavid That one needs ipfs-inactive/interface-js-ipfs-core#227 (comment). Either reverting the commit or fixing the tests. I currently work on a branch with that one reverted trying to fix the other sporadic failures. |
|
One of the recent merges broke the MFS files tests. Reverting ipfs-inactive/interface-js-ipfs-core#227 isn't enough anymore. Update: Reverting b08f21a as well is they key. I'll go from there. |
This reverts commit b08f21a.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#713