-
Notifications
You must be signed in to change notification settings - Fork 299
Conversation
Also, this is bullshit:
Tests taking 17min to run for a one line change that i'm absolutely sure has nothing to do with the tests. this kind of friction is a great way to not receive contributions. I almost gave up and didnt push this at all. Use CI, don't waste contributors' time. I really don't buy that this is the way to prevent bad PRs. let CI show the bad PRs also |
CI is failing due to what appears to be a broken or flaky test, not this PR.
|
BTW, this command ( |
Pls don't purge this commit, as it's being used as a dep for another package: ipfs-shipyard/ipfs-hubot@3a1ce58#r29494914 |
Thanks @jbenet this LGTM. I'll add the command to the spec and also some tests for it and get this merged asap. FWIW I'm +1 on removing the pre-push hook since we have a stable CI setup, strict peer review process and the lead maintainer protocol. |
👍 from me on removing pre-push. As a note, for Before merging this PR, @alanshaw @jbenet can you make sure it gets documented at http://github.com/ipfs/interface-ipfs-core? |
For pre-push ipfs/aegir#243 |
Closing this and continuing at #826 so that we can squash and land cleanly without removing commit For the time being, DO NOT DELETE THIS BRANCH 😃 |
ipfs resolve
command.ipfs resolve
has been an intended command for a long time