This repository has been archived by the owner on Aug 12, 2020. It is now read-only.
Sanitize multihash input. #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 14, 2016
Merged
| throw new Error('not valid multihash') | ||
| } | ||
| if (Buffer.isBuffer(multihash)) { | ||
| return bs58.encode(multihash) |
There was a problem hiding this comment.
We now have the needed methods for this on js-multihash, please use those instead of b58 directly https://github.com/multiformats/js-multihash#api
|
LGTM, thank you :) |
|
LGTM |
|
Squash for the merge :D |
|
Squished and rebased! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root node returned by the exporter uses the hash input, so it's important we make sure it's always a base58-encoded string, since a multihash Buffer is also valid input here.